[Tarantool-patches] [PATCH] cmake: introduce CheckUnwindTables helper

Maxim Kokryashkin m.kokryashkin at tarantool.org
Tue Jan 10 20:36:23 MSK 2023


Hi, Igor!
Thanks for the patch!
LGTM.
 
--
Best regards,
Maxim Kokryashkin
 
  
>Вторник, 10 января 2023, 14:27 +03:00 от Igor Munkin <imun at tarantool.org>:
> 
>Sergey,
>
>Thanks for your review!
>
>On 10.01.23, Sergey Kaplun wrote:
>> Hi, Igor!
>>
>> Thanks for the patch!
>> LGTM!
>
>Added your tag:
>| Reviewed-by: Sergey Kaplun < skaplun at tarantool.org >
>
>>
>
><snipped>
>
>> > (*) Max, could you please check this patch on the Alpine?
>>
>> Should we add the Alpine build and test in our CI in the scope of this
>> commit or with separate one?
>
>Honestly, I don't want to make LuaJIT CI similar to Tarantool one in
>this context: if you commit to support the Linux-based distro zoo in our
>CI, feel free to extend it by yourself. I'd rather introduce FreeBSD (or
>another BSD distro) instead of another fancy Linux with little tweaks
>that differ it from the popular ones.
>
>>
>
><snipped>
>
>>
>> --
>> Best regards,
>> Sergey Kaplun
>
>--
>Best regards,
>IM
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20230110/5d780975/attachment.htm>


More information about the Tarantool-patches mailing list