[Tarantool-patches] [PATCH luajit 5/7] test: add skipcond for all JIT-related tests

[Maxim Kokryashkin]

Hi, Igor!
Thanks for the patch!
Please consider my comments below.
 
`lj-906-fix-err-mem.test.lua` has a `jit.off()`
call in the line 78, which should be wrapped in a pcall.
 
This change should be moved to commit
«build: fix build with JIT disabled»
(a835fb0f778db6e9f0109a66ea1d2ac78fe682e4)
along with the change that I pointed out below. 
> 
>diff --git a/test/tarantool-tests/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/misclib-sysprof-lapi.test.lua
>index 8dc36592..dcde81b9 100644
>--- a/test/tarantool-tests/misclib-sysprof-lapi.test.lua
>+++ b/test/tarantool-tests/misclib-sysprof-lapi.test.lua
>@@ -6,8 +6,10 @@ local test = tap.test("misc-sysprof-lapi"):skipcond({
> 
> test:plan(19)
> 
>-jit.off()
>-jit.flush()
>+-- XXX: Run JIT tuning functions in a safe frame to avoid errors
>+-- thrown when LuaJIT is compiled with JIT engine disabled.
>+pcall(jit.off)
>+pcall(jit.flush)
Same as for the change in `fix-err-mem`. 
> 
> local bufread = require("utils.bufread")
> local symtab = require("utils.symtab")
>@@ -125,5 +127,4 @@ check_mode("C", 100)
> 
> os.remove(TMP_BINFILE)
> 
>-jit.on()
> os.exit(test:check() and 0 or 1)
>--
>2.30.2
--
Best regards,
Maxim Kokryashkin
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20230216/a07d5a29/attachment.htm>