[Tarantool-patches] [PATCH luajit 5/7] test: add skipcond for all JIT-related tests

Igor Munkin imun at tarantool.org
Tue Feb 28 22:02:12 MSK 2023


Thanks for your review! I've fixed the comments you've left.

On 16.02.23, Maxim Kokryashkin wrote:
> Hi, Igor!
> Thanks for the patch!
> Please consider my comments below.
> `lj-906-fix-err-mem.test.lua` has a `jit.off()`
> call in the line 78, which should be wrapped in a pcall.

Hm, thanks for noticing! Fun fact: jit.off doesn't raise the error when
JIT is not compiled. I guess we can left pcall only for jit.flush calls.

> This change should be moved to commit
> «build: fix build with JIT disabled»
> (a835fb0f778db6e9f0109a66ea1d2ac78fe682e4)
> along with the change that I pointed out below. 

As we discussed offline, these changes should be left here. Ignoring.


> --
> Best regards,
> Maxim Kokryashkin

Best regards,

More information about the Tarantool-patches mailing list