[Tarantool-patches] [PATCH luajit 5/7] test: add skipcond for all JIT-related tests
Sergey Kaplun
skaplun at tarantool.org
Tue Feb 14 16:50:27 MSK 2023
Hi, Igor!
Thanks for the patch!
LGTM.
On 13.02.23, Igor Munkin wrote:
<snipped>
> diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/misclib-memprof-lapi.test.lua
> index accb1ee1..e2701c13 100644
> --- a/test/tarantool-tests/misclib-memprof-lapi.test.lua
> +++ b/test/tarantool-tests/misclib-memprof-lapi.test.lua
> @@ -1,8 +1,6 @@
> -- XXX: This comment is a reminder to reimplement memprof tests
> -- assertions to make them more indepentent to the changes made.
> --- Now I just leave this 5 lines comment to preserve line numbers.
> --- TODO: This line will be removed in the next patch.
> --- TODO: This line will be removed in the next patch.
> +-- Now I just leave this 3 lines comment to preserve line numbers.
Side note: Still don't like this approach a lot, but, who cares.
> local tap = require("tap")
> local test = tap.test("misc-memprof-lapi"):skipcond({
> ["Memprof is implemented for x86_64 only"] = jit.arch ~= "x86" and
> @@ -18,8 +16,10 @@ local jit_opt_default = {
> "minstitch=0",
> }
<snipped>
> --
> 2.30.2
>
--
Best regards,
Sergey Kaplun
More information about the Tarantool-patches
mailing list