[Tarantool-patches] [PATCH luajit] FFI: Always fall back to metamethods for cdata length/concat.

[Maxim Kokryashkin]

Hi, Sergey!
Thanks for the clarification!
LGTM
 
--
Best regards,
Maxim Kokryashkin
 
  
>Понедельник, 12 сентября 2022, 11:10 +03:00 от Sergey Kaplun <skaplun at tarantool.org>:
> 
>Hi, Maxim!
>
>Thanks for the review!
>
>On 08.09.22, Maxim Kokryashkin wrote:
>>
>> Hi, Sergey!
>> Thanks for the patch!
>> Please consider the single comment below:
>>  
>> <snipped>
>> >
>> > src/lj_carith.c | 3 +--
>> > src/lj_crecord.c | 6 ++++--
>> > test/tarantool-tests/fix-cdata-concat.test.lua | 15 +++++++++++++++
>> > 3 files changed, 20 insertions(+), 4 deletions(-)
>> > create mode 100644 test/tarantool-tests/fix-cdata-concat.test.lua
>> Besides everything that Sergos has already said, I wonder why you didn't include any changes in "lj_carith.h" and "lib_ffi.c" from the original patch?
>
>They were annihilated during the cherry-pick. See the following changes
>in the merge commit:
>https://github.com/LuaJIT/LuaJIT/commit/d5e12d5174720fbd3c5fad4e02da5850b8433057
>
>>  
>> <snipped>
>> --
>> Best regards,
>> Maxim Kokryashkin
>
>--
>Best regards,
>Sergey Kaplun
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20220913/d1c66ef9/attachment.htm>