[Tarantool-patches] [PATCH luajit] FFI: Always fall back to metamethods for cdata length/concat.
skaplun at tarantool.org
Mon Sep 12 11:07:55 MSK 2022
Thanks for the review!
On 08.09.22, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the patch!
> Please consider the single comment below:
> > src/lj_carith.c | 3 +--
> > src/lj_crecord.c | 6 ++++--
> > test/tarantool-tests/fix-cdata-concat.test.lua | 15 +++++++++++++++
> > 3 files changed, 20 insertions(+), 4 deletions(-)
> > create mode 100644 test/tarantool-tests/fix-cdata-concat.test.lua
> Besides everything that Sergos has already said, I wonder why you didn't include any changes in "lj_carith.h" and "lib_ffi.c" from the original patch?
They were annihilated during the cherry-pick. See the following changes
in the merge commit:
> Best regards,
> Maxim Kokryashkin
More information about the Tarantool-patches