<HTML><BODY><div>Hi, Sergey!</div><div>Thanks for the clarification!</div><div>LGTM</div><div> </div><div data-signature-widget="container"><div spellcheck="false" data-signature-widget="content"><div>--<br>Best regards,</div><div>Maxim Kokryashkin</div></div></div><div> </div><div> </div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Понедельник, 12 сентября 2022, 11:10 +03:00 от Sergey Kaplun <skaplun@tarantool.org>:<br> <div id=""><div class="js-helper js-readmsg-msg"><div><div id="style_16629702352101547349_BODY">Hi, Maxim!<br><br>Thanks for the review!<br><br>On 08.09.22, Maxim Kokryashkin wrote:<br>><br>> Hi, Sergey!<br>> Thanks for the patch!<br>> Please consider the single comment below:<br>> <br>> <snipped><br>> ><br>> > src/lj_carith.c | 3 +--<br>> > src/lj_crecord.c | 6 ++++--<br>> > test/tarantool-tests/fix-cdata-concat.test.lua | 15 +++++++++++++++<br>> > 3 files changed, 20 insertions(+), 4 deletions(-)<br>> > create mode 100644 test/tarantool-tests/fix-cdata-concat.test.lua<br>> Besides everything that Sergos has already said, I wonder why you didn't include any changes in "lj_carith.h" and "lib_ffi.c" from the original patch?<br><br>They were annihilated during the cherry-pick. See the following changes<br>in the merge commit:<br><a href="https://github.com/LuaJIT/LuaJIT/commit/d5e12d5174720fbd3c5fad4e02da5850b8433057" target="_blank">https://github.com/LuaJIT/LuaJIT/commit/d5e12d5174720fbd3c5fad4e02da5850b8433057</a><br><br>> <br>> <snipped><br>> --<br>> Best regards,<br>> Maxim Kokryashkin<br><br>--<br>Best regards,<br>Sergey Kaplun</div></div></div></div></blockquote><div> </div></BODY></HTML>