[Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths

[Igor Munkin]

Sergey,

Thanks for your review!

On 08.03.21, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch!
> 
> LGTM!

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun at tarantool.org>

> 
> `${LUACHECK_SOURCE_DIR}` and `${LUACHECK_BINARY_DIR}` look more
> consistent for me (according to other variables naming), but it's up to
> you.
> Feel free to ignore.

Fixed, squashed, force-pushed to the branch.

> 
> On 06.03.21, Igor Munkin wrote:
> > Unfortunately, luacheck doesn't handle the working directory or one used
> > in options if it is not a real path. As a result of this patch both
> > PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR are resolved prior to be used
> > within luacheck target custom command.
> > 
> > The issue has been already fixed in Tarantool repo after applying
> 
> Nit: "same issue" or "similar issue"
> Feel free to ignore.

The definite article does its job here.

Ignoring.

> 
> > af448464d15f60b87f1c9ef41a7816911c889459 ('tools: fix luacheck
> > invocation in different cases'), and this patch is necessary, since
> > <LuaJIT-luacheck> is the dependency for Tarantool <luacheck> target.
> > 
> > Relates to mpeterv/luacheck#208
> > 
> > Reported-by: Alexander Turenko <alexander.turenko at tarantool.org>
> > Signed-off-by: Igor Munkin <imun at tarantool.org>
> > ---
> 
> <snipped>
> 
> > 
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM