[Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths

Igor Munkin imun at tarantool.org
Wed Mar 10 19:25:21 MSK 2021


I've checked the patchset into all long-term branches in
tarantool/luajit and bumped a new version in 1.10, 2.6, 2.7 and master.

On 06.03.21, Igor Munkin wrote:
> Unfortunately, luacheck doesn't handle the working directory or one used
> in options if it is not a real path. As a result of this patch both
> PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR are resolved prior to be used
> within luacheck target custom command.
> 
> The issue has been already fixed in Tarantool repo after applying
> af448464d15f60b87f1c9ef41a7816911c889459 ('tools: fix luacheck
> invocation in different cases'), and this patch is necessary, since
> <LuaJIT-luacheck> is the dependency for Tarantool <luacheck> target.
> 
> Relates to mpeterv/luacheck#208
> 
> Reported-by: Alexander Turenko <alexander.turenko at tarantool.org>
> Signed-off-by: Igor Munkin <imun at tarantool.org>
> ---
> 
> Branch: https://github.com/tarantool/luajit/tree/imun/luacheck-realpath
> CI is green on this branch (see the tick near the HEAD commit):
> https://github.com/tarantool/tarantool/tree/imun/fix-luacheck-invocation
> 
>  test/CMakeLists.txt | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
> 

<snipped>

> -- 
> 2.25.0
> 

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list