[Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths

Sergey Kaplun skaplun at tarantool.org
Mon Mar 8 22:26:35 MSK 2021

Hi, Igor!

Thanks for the patch!


consistent for me (according to other variables naming), but it's up to
Feel free to ignore.

On 06.03.21, Igor Munkin wrote:
> Unfortunately, luacheck doesn't handle the working directory or one used
> in options if it is not a real path. As a result of this patch both
> PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR are resolved prior to be used
> within luacheck target custom command.
> The issue has been already fixed in Tarantool repo after applying

Nit: "same issue" or "similar issue"
Feel free to ignore.

> af448464d15f60b87f1c9ef41a7816911c889459 ('tools: fix luacheck
> invocation in different cases'), and this patch is necessary, since
> <LuaJIT-luacheck> is the dependency for Tarantool <luacheck> target.
> Relates to mpeterv/luacheck#208
> Reported-by: Alexander Turenko <alexander.turenko at tarantool.org>
> Signed-off-by: Igor Munkin <imun at tarantool.org>
> ---



Best regards,
Sergey Kaplun

More information about the Tarantool-patches mailing list