[Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths

Igor Munkin imun at tarantool.org
Wed Mar 10 03:14:16 MSK 2021


Sasha,

Thanks for your review!

On 08.03.21, Alexander Turenko wrote:
> LGTM.

Added your tag:
| Reviewed-by: Alexander Turenko <alexander.turenko at tarantool.org>

> 
> Just curious, why you don't need exclusion of a build directory for the
> case, when it is inside the source directory?

As we discussed before, there is a single Lua file within build
directory: jit/vmdef.lua. Hence, it's enough to exclude only this file.

> 
> WBR, Alexander Turenko.
> 
> > Branch: https://github.com/tarantool/luajit/tree/imun/luacheck-realpath
> > CI is green on this branch (see the tick near the HEAD commit):
> > https://github.com/tarantool/tarantool/tree/imun/fix-luacheck-invocation

-- 
Best regards,
IM


More information about the Tarantool-patches mailing list