[Tarantool-patches] [PATCH 5/5] Apply Clang formatter
v.shpilevoy at tarantool.org
Tue Nov 10 23:38:43 MSK 2020
> On 02 Nov 22:05, Vladislav Shpilevoy wrote:
>> Ok. I will review the whole patch, every single line. Don't push
>> it beforehand then.
> In my previous e-mail I've explicitly stated that current formatter
> is not suitable for us. Quote:
>>> After all, having p.3 and p.8 unresolved I guess we cannot proceed
>>> without changes to formatter.
> Please, see what does it mean here .
>  - https://translate.google.com/#view=home&op=translate&sl=auto&tl=ru&text=After%20all%2C%20having%20p.3%20and%20p.8%20unresolved%20I%20guess%20we%20cannot%20proceed%20without%20changes%20to%20formatter.
Ok, lets play quotes. Here is yours:
I am not sure. Anyway I think this is not a blocker for having fully automated
Talking of this quote:
After all, having p.3 and p.8 unresolved I guess we cannot proceed
without changes to formatter.
It is not the same as saying that we won't use the formatter. You just said,
you will try to fix review points 3 and 8. Which were not even the worst.
Which leads to the point you are ok with the other issues. Tons of
other issues, as I found in the detailed review. And I am not ok with these
More information about the Tarantool-patches