[Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function

[Maria Khaydich]

>Четверг, 12 марта 2020, 16:29 +03:00 от Konstantin Osipov <kostja.osipov at gmail.com>:
> 
>* Maria Khaydich < maria.khaydich at tarantool.org > [20/03/11 19:02]:
>>
>> Calling box.cfg{} more than once does not normally cause any errors
>> (even though it might not have any effect). In contrast, assigning
>> it to some variable and then using it after the box was configured
>> caused an error since the method was overwritten by the initial call
>> of <load_cfg>.
>>  
>> The patch fixes this issue making box.cfg behave consistently in both
>> scenarios and is a follow-up for box: make box.execute idempotent function.
>
>Did you benchmark it?
 
Do you think we need to? There’s basically one extra condition in the patch. I don’t see how it might degrade performance.
 
>
>>  
>> Follow-up #4231
>> ---
>> Issue:
>>  https://github.com/tarantool/tarantool/issues/4231  
>> Branch:
>>  https://github.com/tarantool/tarantool/compare/eljashm/gh-4231-box.execute-immutable-function  
>
>--
>Konstantin Osipov, Moscow, Russia 
 
 
--
Maria Khaydich
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20200312/68140a76/attachment.html>