[Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function

Konstantin Osipov kostja.osipov at gmail.com
Thu Mar 12 23:00:24 MSK 2020


* Maria Khaydich <maria.khaydich at tarantool.org> [20/03/12 22:26]:
> >> Calling box.cfg{} more than once does not normally cause any errors
> >> (even though it might not have any effect). In contrast, assigning
> >> it to some variable and then using it after the box was configured
> >> caused an error since the method was overwritten by the initial call
> >> of <load_cfg>.
> >>  
> >> The patch fixes this issue making box.cfg behave consistently in both
> >> scenarios and is a follow-up for box: make box.execute idempotent function.
> >
> >Did you benchmark it?
>  
> Do you think we need to? There’s basically one extra condition
> in the patch. I don’t see how it might degrade performance.

It's not a one more condition, it's one more FFI C call.

-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list