<HTML><BODY><div> <blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">Четверг, 12 марта 2020, 16:29 +03:00 от Konstantin Osipov <kostja.osipov@gmail.com>:<br> <div id=""><div class="js-helper js-readmsg-msg"><style type="text/css"></style><div><div id="style_15840197780176168737_BODY">* Maria Khaydich <<a href="/compose?To=maria.khaydich@tarantool.org">maria.khaydich@tarantool.org</a>> [20/03/11 19:02]:<br>><br>> Calling box.cfg{} more than once does not normally cause any errors<br>> (even though it might not have any effect). In contrast, assigning<br>> it to some variable and then using it after the box was configured<br>> caused an error since the method was overwritten by the initial call<br>> of <load_cfg>.<br>> <br>> The patch fixes this issue making box.cfg behave consistently in both<br>> scenarios and is a follow-up for box: make box.execute idempotent function.<br><br>Did you benchmark it?</div></div></div></div></blockquote></div><div> </div><div>Do you think we need to? There’s basically one extra condition in the patch. I don’t see how it might degrade performance.</div><div> </div><div><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;"><div><div class="js-helper js-readmsg-msg"><div><div><br>> <br>> Follow-up #4231<br>> ---<br>> Issue:<br>> <a href="https://github.com/tarantool/tarantool/issues/4231" target="_blank">https://github.com/tarantool/tarantool/issues/4231</a> <br>> Branch:<br>> <a href="https://github.com/tarantool/tarantool/compare/eljashm/gh-4231-box.execute-immutable-function" target="_blank">https://github.com/tarantool/tarantool/compare/eljashm/gh-4231-box.execute-immutable-function</a> <br><br>--<br>Konstantin Osipov, Moscow, Russia</div></div></div></div></blockquote> <div> </div><div data-signature-widget="container"><div data-signature-widget="content"><div>--<br>Maria Khaydich</div></div></div><div> </div></div></BODY></HTML>