[Tarantool-patches] [PATCH v3] relay: fix join vclock obtainment in relay_initial_join

[Ilya Kosarev]

Hi!

Thanks for your review.

Sent fixed patch in reply to this message:
https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012195.html  


>Четверг, 31 октября 2019, 1:16 +03:00 от Vladislav Shpilevoy <v.shpilevoy at tarantool.org>:
>
>Hi! Thanks for the patch!
>
>LGTM, except the comment below.
>
>> diff --git a/src/box/wal.h b/src/box/wal.h
>> index b76b0a41f..827b0fb85 100644
>> --- a/src/box/wal.h
>> +++ b/src/box/wal.h
>> @@ -182,9 +182,10 @@ wal_mode();
>>  /**
>>   * Wait until all submitted writes are successfully flushed
>>   * to disk. Returns 0 on success, -1 if write failed.
>> + * Corresponding vclock is returned in @vclock unless it is NULL.
>>   */
>For parameter reference, please, use '@a <param_name>' syntax,
>not '@<param_name>'. See doxygen documentation on @a.
>
>>  int
>> -wal_sync(void);
>> +wal_sync(struct vclock *vclock);
>>


-- 
Ilya Kosarev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20191101/6c3440b5/attachment.html>