<HTML><BODY><span style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;">Hi!</span><br style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;"><br style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;"><span style="font-family: Arial, Tahoma, Verdana, sans-serif;" data-mce-style="font-family: Arial, Tahoma, Verdana, sans-serif;">Thanks for your review.<br><br></span>Sent fixed patch in reply to this message:<br><a href="https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012195.html">https://lists.tarantool.org/pipermail/tarantool-patches/2019-November/012195.html</a> <br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Четверг, 31 октября 2019, 1:16 +03:00 от Vladislav Shpilevoy <v.shpilevoy@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<div id="style_15724737950988339085_BODY">Hi! Thanks for the patch!<br>
<br>
LGTM, except the comment below.<br>
<br>
> diff --git a/src/box/wal.h b/src/box/wal.h<br>
> index b76b0a41f..827b0fb85 100644<br>
> --- a/src/box/wal.h<br>
> +++ b/src/box/wal.h<br>
> @@ -182,9 +182,10 @@ wal_mode();<br>
> /**<br>
> * Wait until all submitted writes are successfully flushed<br>
> * to disk. Returns 0 on success, -1 if write failed.<br>
> + * Corresponding vclock is returned in @vclock unless it is NULL.<br>
> */<br>
For parameter reference, please, use '@a <param_name>' syntax,<br>
not '@<param_name>'. See doxygen documentation on @a.<br>
<br>
> int<br>
> -wal_sync(void);<br>
> +wal_sync(struct vclock *vclock);<br>
><br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
<br>-- <br>Ilya Kosarev<br></BODY></HTML>