[Tarantool-patches] [PATCH] socket: better args handling for	connect()/bind()
    Alexander Turenko 
    alexander.turenko at tarantool.org
       
    Fri Nov  1 15:32:42 MSK 2019
    
    
  
Please, rebase your commits on recent master and apply comments below.
> socket: better args handling for connect()/bind()
I would say about validation rather then handling.
>
> Check args types in socket.connect() and socket.bind() functions.
> 'host' should be a string and 'port' should be a string or a
> number.
> 
> Part of #4138
It is better to place this commit before one that closes the issue.
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4138-getaddrinfo
> Issue: https://github.com/tarantool/tarantool/issues/4138
> @@ -1569,7 +1570,8 @@ local function lsocket_connect(host, port)
>  end
>  
>  local function lsocket_bind(host, port, backlog)
> -    if host == nil or port == nil then
> +    if type(host) ~= 'string' or (type(port) ~= 'string' and
> +        type(port) ~= 'number') then
I would check backport against 'number' too (if it present).
> +socket.connect(127.0.0.1, 3301)
> +---
> +- error: '[string "socket.connect(127.0.0.1, 3301) "]:1: malformed number near ''127.0.0.1'''
Did you read this error? It is the parsing error from Lua interpreter.
    
    
More information about the Tarantool-patches
mailing list