[tarantool-patches] Re: [PATCH 11/12] vinyl: don't use IPROTO_SELECT type for key statements

Konstantin Osipov kostja at tarantool.org
Thu Feb 21 14:16:34 MSK 2019


* Vladimir Davydov <vdavydov.dev at gmail.com> [19/02/21 13:31]:
> To differentiate between key and tuple statements in comparators, we set
> IPROTO_SELECT type for key statements. As a result, we can't use key
> statements in the run iterator directly although secondary index runs do
> store statements in key format. Instead we create surrogate tuples
> filling missing fields with NULLs. This won't play nicely with multikey
> indexes so we need to teach iterators to deal with statements in key
> format. The first step in this direction is dropping IPROTO_SELECT and
> starting to identify key statements by format instead.

It's amazing how simple this patch is, it's OK to push provided we
decide to push the final patch.


-- 
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov




More information about the Tarantool-patches mailing list