[tarantool-patches] Re: [PATCH 07/12] vinyl: sanitize full/empty key stmt detection

Vladimir Davydov vdavydov.dev at gmail.com
Thu Feb 21 15:11:04 MSK 2019

On Thu, Feb 21, 2019 at 02:10:51PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [19/02/21 13:31]:
> > Historically, we use tuple_field_count to check whether a statement
> > represents an empty key (match all) or a full key (point lookup): if
> > the number of fields in a tuple is greater than or equal to the number
> > of parts in a key definition, it can be used as a full key; if the
> > number of fields is zero, then the statement represents an empty key.
> I don't understand the purpose of this patch yet.

Well, it's just a technical debt left from the json index patch.
In fact, the code may be buggy/suboptimal without this patch. E.g.
tuple cache heavily relays on whether the passed statement is a full
or a partial key. If it fails to detect it, it won't store a chain
when it should. We used to use tuple_field_count to check whether
a tuple represents a full key or not:

	if (tuple_field_count(tuple) >= cmp_def->part_count)
		/* full key */

With json indexes this isn't correct anymore, because the same field may
be indexed multiple times, e.g. [2].path1 and [2].path2. Due to this,
the full key check may fail for a full tuple, which is obviously wrong
although a full tuple must have all key parts defined. This patch makes
those check work only tuples representing keys while assuming that all
tuples may be used as full keys. And it wraps it inside a pair of helper

More information about the Tarantool-patches mailing list