[tarantool-patches] Re: [PATCH 06/12] vinyl: move vy_key_dup to generic code

Vladimir Davydov vdavydov.dev at gmail.com
Thu Feb 21 14:52:45 MSK 2019

On Thu, Feb 21, 2019 at 02:04:12PM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev at gmail.com> [19/02/21 13:31]:
> > This helper function has nothing to do with vinyl - it's simply
> > duplicates a msgpack array. Let's move it to tuple.c and rename
> > it to key_dup.
> Why to tuple.c and not in to msgpack? 

Because there's no place for msgpack helpers inside tarantool. Besides,
other functions operating on raw keys (which are msgpack arrays) have
key_ prefix, e.g. key_compare.

> I don't like what this function is doing and how it's doing it, so
> I'd rather bury it in vinyl or get rid of it, not make a generic
> one.

OK. I just wanted to expel it from vinyl code so as to avoid confusion
between vinyl key statement and raw key msgpack.

More information about the Tarantool-patches mailing list