[Tarantool-patches] [PATCH v2 04/16] sql: rename sqlPrepare() to sql_compile()

Konstantin Osipov kostja.osipov at gmail.com
Wed Dec 4 14:39:13 MSK 2019


* Nikita Pettik <korablev at tarantool.org> [19/11/21 10:00]:
> sql_prepare() is going not only to compile statement, but also to save it
> to the prepared statement cache. So we'd better rename sqlPrepare()
> which is static wrapper around sql_prepare() and make it non-static.
> Where it is possible let's use sql_compile() instead of sql_prepare().

I'd call it sql_stmt_create, but sql_compile is fine as well.
My point is, I would try to make the api more object-oriented.

Maybe sql_stmt_compile?

Anyway, lgtm.

-- 
Konstantin Osipov, Moscow, Russia


More information about the Tarantool-patches mailing list