[tarantool-patches] Re: [PATCH v1 1/3] sql: remove mayAbort field from struct Parse

[Imeev Mergen]

Hi! Thank you for review!

On 4/15/19 5:06 PM, n.pettik wrote:
>
>> On 12 Apr 2019, at 15:34, imeevma at tarantool.org wrote:
>>
>> Currently, the mayAbort field is used only in one place in debug
>> mode and is not used in non-debug mode. This patch removes this
>> field.
> Could you be more specific when pointing out the reason of removal?
> What was the feature you are removing and why it can be removed?
> Argument like ‘it is used only in debug mode’ doesn’t seem to be
> convincing enough.
I'll add that this allows us to remove SQL errcode SQL_CONSTRAINT.
>
>> Part of #4074
> Code involved in this patch doesn’t throw any errors,
> so why it is a part of diag replacement?
>
> I guess this code clean-up can be OK, but we must
> be sure that this functionality can’t be applied to our
> SQL implementation.
>
In fact, this code works with the error code SQL_CONSTRAINT, and
if we want to remove this error code, we must think of a way to
replace it with some other similar checks. I think this will make
the code less understandable.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20190422/573cd1c2/attachment.html>