<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi! Thank you for review!<br>
</p>
<div class="moz-cite-prefix">On 4/15/19 5:06 PM, n.pettik wrote:<br>
</div>
<blockquote type="cite"
cite="mid:C89F4290-D9FA-4CF0-9FB1-285A1E208D63@tarantool.org">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On 12 Apr 2019, at 15:34, <a class="moz-txt-link-abbreviated" href="mailto:imeevma@tarantool.org">imeevma@tarantool.org</a> wrote:
Currently, the mayAbort field is used only in one place in debug
mode and is not used in non-debug mode. This patch removes this
field.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Could you be more specific when pointing out the reason of removal?
What was the feature you are removing and why it can be removed?
Argument like ‘it is used only in debug mode’ doesn’t seem to be
convincing enough.</pre>
</blockquote>
I'll add that this allows us to remove SQL errcode <span
class="blob-code-inner">SQL_CONSTRAINT.</span>
<blockquote type="cite"
cite="mid:C89F4290-D9FA-4CF0-9FB1-285A1E208D63@tarantool.org">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Part of #4074
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Code involved in this patch doesn’t throw any errors,
so why it is a part of diag replacement?
I guess this code clean-up can be OK, but we must
be sure that this functionality can’t be applied to our
SQL implementation.
</pre>
</blockquote>
In fact, this code works with the error code SQL_CONSTRAINT, and<br>
if we want to remove this error code, we must think of a way to<br>
replace it with some other similar checks. I think this will make<br>
the code less understandable.<br>
<span class="blob-code-inner"><br>
</span>
</body>
</html>