[tarantool-patches] Re: [PATCH v1 1/3] sql: remove mayAbort field from struct Parse

n.pettik korablev at tarantool.org
Mon Apr 15 17:06:32 MSK 2019



> On 12 Apr 2019, at 15:34, imeevma at tarantool.org wrote:
> 
> Currently, the mayAbort field is used only in one place in debug
> mode and is not used in non-debug mode. This patch removes this
> field.

Could you be more specific when pointing out the reason of removal?
What was the feature you are removing and why it can be removed?
Argument like ‘it is used only in debug mode’ doesn’t seem to be
convincing enough.

> Part of #4074

Code involved in this patch doesn’t throw any errors,
so why it is a part of diag replacement?

I guess this code clean-up can be OK, but we must
be sure that this functionality can’t be applied to our
SQL implementation.





More information about the Tarantool-patches mailing list