[tarantool-patches] Re: [PATCH v2 2/2] sql: remove struct Enc

Vladislav Shpilevoy v.shpilevoy at tarantool.org
Wed Aug 29 02:21:17 MSK 2018


Thanks for the fixes! Now the whole patchset LGTM.

As I know, for Nikita as well, so Kirill Yu., look at
it, please.

>> 4. Finish a sentence with the dot. Btw the comment
>> is not related to the code. Below you do not whether
>> the index is unique or not.
>> 5. "Did't defined" - corrupted phrase. Rather "did't define".
>> But the whole comment looks strange as well as the previous,
>> and out of its place. Just remove it.
> You know, I've just copied existed peace of code with all comments.
> I've get rid off those two comments at all now.

I know, but it is not an excuse. After the patch was pushed, git blame
would show your name against these lines.




More information about the Tarantool-patches mailing list