[tarantool-patches] Re: [PATCH v2 2/2] sql: remove struct Enc

[Kirill Shcherbatov]

> Thanks for the patch! See 7 comments below and a
> commit on the branch.
Hi. Thank you for review
> 1. Double include of region.h.
done.
> 2. Static.
fixed.

> 3. No comment.
/**
 * Encode index options @opts into message pack with @stream.
 * @param stream Message Pack Stream to use on encode.
 * @param opts Index options to encode.
 */
static void
mpstream_encode_index_opts(struct mpstream *stream, struct index_opts *opts)

> 4. Finish a sentence with the dot. Btw the comment
> is not related to the code. Below you do not whether
> the index is unique or not.
> 5. "Did't defined" - corrupted phrase. Rather "did't define".
> But the whole comment looks strange as well as the previous,
> and out of its place. Just remove it.
You know, I've just copied existed peace of code with all comments.
I've get rid off those two comments at all now.

> 6. If 'raw == NULL' you still try to use it in box_update.
My fault. Fixed.

> 7. Here https://github.com/tarantool/tarantool/commit/0d8b0c5641ec4c27547b1d0121bb1e0a641b149b
> I see changes not relevant to this patch and not presented in the
> email. I paste them bellow:
Done.