[tarantool-patches] Re: [PATCH v2 0/2] sql: remove struct Enc

[Vladislav Shpilevoy]

Hi! Thanks for the patchset!

Next time, please, answer on my review remarks
in a separate reply letter in the old thread if
you send a new version in a new thread.

On 27/08/2018 08:11, Kirill Shcherbatov wrote:
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3545-remove-enc-struct
> Issue: https://github.com/tarantool/tarantool/issues/3545
> 
> We shouldn't use legacy Enc structure in SQL as we have
> featured class mpstream in tarantool core. With this path
> all allocations temporally commited with mpstream initialized

Typo: 'commited' -> 'committed'.

> on region and then duplicated in dynamic persistent memory via
> sqlite3DbMallocRaw.
> As a first step, we've moved mpstream API in core lib and reworked
> all legacy interfaces.
> 
> Changes in v2:
>   - rebased to master, merged with new func
>     sql_index_update_table_name.
>   - reworked legacy code with new mpstream library API
> 
> Kirill Shcherbatov (2):
>    box: export mpstream methods to core
>    sql: remove struct Enc
> 
>   src/CMakeLists.txt         |   1 +
>   src/box/lua/call.c         |  11 +-
>   src/box/lua/misc.cc        |   1 +
>   src/box/lua/net_box.c      | 127 ++++++------
>   src/box/lua/tuple.c        |  23 +--
>   src/box/sql.c              | 473 +++++++++++++++++++++++----------------------
>   src/box/sql/build.c        | 156 ++++++++-------
>   src/box/sql/tarantoolInt.h |  80 +++++---
>   src/box/sql/trigger.c      |  62 +++---
>   src/lua/msgpack.c          | 166 ++--------------
>   src/lua/msgpack.h          | 102 +---------
>   src/mpstream.c             | 205 ++++++++++++++++++++
>   src/mpstream.h             | 124 ++++++++++++
>   13 files changed, 845 insertions(+), 686 deletions(-)
>   create mode 100644 src/mpstream.c
>   create mode 100644 src/mpstream.h
>