[tarantool-patches] Re: [PATCH v2 1/2] box: export mpstream methods to core

[Kirill Shcherbatov]

Hi. Thank you for comments.
> 1. As I said in the previous review, reserve and
> reserve_slow are not split in two functions just
> for case. There is a reason. And your patch
> destroys the benefit of reserve/reserve_slow
> splitting. I paste it here:
Sorry for misunderstanding, I didn't catch this words. Only why does mpstream is a header-only library.
-void
-mpstream_flush(struct mpstream *stream);
+static inline void
+mpstream_flush(struct mpstream *stream)

-char *
-mpstream_reserve(struct mpstream *stream, size_t size);
+static inline char *
+mpstream_reserve(struct mpstream *stream, size_t size)

-void
-mpstream_advance(struct mpstream *stream, size_t size);
+static inline void
+mpstream_advance(struct mpstream *stream, size_t size)


> 2. It is not 'LUA' anymore.
Ok, fixed-#ifndef TARANTOOL_LUA_MPSTREAM_H_INCLUDED
-#define TARANTOOL_LUA_MPSTREAM_H_INCLUDED
+#ifndef TARANTOOL_MPSTREAM_H_INCLUDED
+#define TARANTOOL_MPSTREAM_H_INCLUDED