[tarantool-patches] Re: [tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes

[GLEB SKIBA]

Hello. I fix it.


>Четверг, 26 апреля 2018, 12:02 +03:00 от Kirill Yukhin <kyukhin at tarantool.org>:
>
>Hello,
>On 25 апр 18:44, n.pettik wrote:
>> 
>> > LGTM. Nikita, can you look?
>> 
>> Hello. Generally speaking, patch looks OK to me as well.
>> 
>> I don’t like error message: it is possible to make it more
>> intelligible. To do it, you need to left parser as is, but in
>> sqlite3CreateIndex() check that ‘WHERE’ arg is empty.
>> On the other hand, this is temporary ban and to enable this
>> feature back, it is enough to revert this patch, so never mind.
>
>
>New test fails for me:
>/export/kyukhin/tarantool/src/test$ ./test-run.py --builddir ../../bld sql-tap/gh-2165-remove-support-partial-indexes.test.lua
>
>======================================================================================
>WORKR TEST                                            PARAMS          RESULT
>---------------------------------------------------------------------------------
>Traceback (most recent call last):
>  File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 534, in run
>    result = self._run(*self.args, **self.kwargs)
>  File "/export/kyukhin/tarantool/src/test-run/lib/test.py", line 38, in _run
>    self.callable(*self.callable_args, **self.callable_kwargs)
>  File "/export/kyukhin/tarantool/src/test-run/lib/app_server.py", line 18, in run_server
>    server.process = Popen(execs, stdout=PIPE, stderr=PIPE, cwd=cwd)
>  File "/usr/lib/python2.7/dist-packages/gevent/subprocess.py", line 534, in __init__
>    reraise(*exc_info)
>  File "/usr/lib/python2.7/dist-packages/gevent/subprocess.py", line 503, in __init__
>    restore_signals, start_new_session)
>  File "/usr/lib/python2.7/dist-packages/gevent/subprocess.py", line 1253, in _execute_child
>    raise child_exception
>OSError: [Errno 13] Permission denied
><TestRunGreenlet at 0x7f25b3d20730 info='None'> failed with OSError
>
>[001] sql-tap/gh-2165-remove-support-partial-indexes.test.lua
>[001] TAP13 parse failed: Missing plan in the TAP source
>[001] [ new ]
>---------------------------------------------------------------------------------
>Statistics:
>* new: 1
>
>--
>Regards, Kirill Yukhin
>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.tarantool.org/pipermail/tarantool-patches/attachments/20180426/ec3309b6/attachment.html>