[tarantool-patches] Re: [PATCH v3 0/4] sql: Removed Column fields to server with region allocations

[Vladislav Shpilevoy]

Hello. Thanks for contributing! See below my 1 comment.

On 25/04/2018 19:52, Kirill Shcherbatov wrote:
> Branch: http://github.com/tarantool/tarantool/tree/gh-3272-no-sql-names
> Issue: https://github.com/tarantool/tarantool/issues/3272

Please, provide a description of the patchset.

> 
> Kirill Shcherbatov (4):
>    sql: Fix code style in sqlite3Pragma.
>    sql: Remove zName and nColumn from SQL.
>    sql: Removed type from SQL.
>    sql: Region-based allocations.
> 
>   src/box/space_def.c     |  29 ++++---
>   src/box/sql.c           |  90 ++++++++++++++++---
>   src/box/sql.h           |  32 +++++++
>   src/box/sql/alter.c     |  32 ++++---
>   src/box/sql/analyze.c   |   5 +-
>   src/box/sql/build.c     | 226 +++++++++++++++++++++++-------------------------
>   src/box/sql/delete.c    |   6 +-
>   src/box/sql/expr.c      |  11 +--
>   src/box/sql/fkey.c      |  20 ++---
>   src/box/sql/insert.c    |  55 ++++++------
>   src/box/sql/pragma.c    |  84 +++++++++---------
>   src/box/sql/prepare.c   |  26 +++---
>   src/box/sql/resolve.c   |  16 ++--
>   src/box/sql/select.c    | 120 ++++++++++++++-----------
>   src/box/sql/sqliteInt.h |   8 +-
>   src/box/sql/tokenize.c  |   3 +
>   src/box/sql/trigger.c   |   2 +
>   src/box/sql/update.c    |  29 ++++---
>   src/box/sql/util.c      |   9 --
>   src/box/sql/where.c     |   6 +-
>   src/box/sql/wherecode.c |   2 +-
>   src/box/sql/whereexpr.c |   4 +-
>   22 files changed, 477 insertions(+), 338 deletions(-)
>