<HTML><BODY>Hello. I fix it.<br><br><br><blockquote style="border-left:1px solid #0857A6; margin:10px; padding:0 0 0 10px;">
Четверг, 26 апреля 2018, 12:02 +03:00 от Kirill Yukhin <kyukhin@tarantool.org>:<br>
<br>
<div id="">
<div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e.mail.ru/">
<div id="style_15247333520000000733_BODY">Hello,<br>
On 25 апр 18:44, n.pettik wrote:<br>
> <br>
> > LGTM. Nikita, can you look?<br>
> <br>
> Hello. Generally speaking, patch looks OK to me as well.<br>
> <br>
> I don’t like error message: it is possible to make it more<br>
> intelligible. To do it, you need to left parser as is, but in<br>
> sqlite3CreateIndex() check that ‘WHERE’ arg is empty.<br>
> On the other hand, this is temporary ban and to enable this<br>
> feature back, it is enough to revert this patch, so never mind.<br>
<br>
<br>
New test fails for me:<br>
/export/kyukhin/tarantool/src/test$ ./test-run.py --builddir ../../bld sql-tap/gh-2165-remove-support-partial-indexes.test.lua<br>
<br>
======================================================================================<br>
WORKR TEST PARAMS RESULT<br>
---------------------------------------------------------------------------------<br>
Traceback (most recent call last):<br>
File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 534, in run<br>
result = self._run(*self.args, **self.kwargs)<br>
File "/export/kyukhin/tarantool/src/test-run/lib/test.py", line 38, in _run<br>
self.callable(*self.callable_args, **self.callable_kwargs)<br>
File "/export/kyukhin/tarantool/src/test-run/lib/app_server.py", line 18, in run_server<br>
server.process = Popen(execs, stdout=PIPE, stderr=PIPE, cwd=cwd)<br>
File "/usr/lib/python2.7/dist-packages/gevent/subprocess.py", line 534, in __init__<br>
reraise(*exc_info)<br>
File "/usr/lib/python2.7/dist-packages/gevent/subprocess.py", line 503, in __init__<br>
restore_signals, start_new_session)<br>
File "/usr/lib/python2.7/dist-packages/gevent/subprocess.py", line 1253, in _execute_child<br>
raise child_exception<br>
OSError: [Errno 13] Permission denied<br>
<TestRunGreenlet at 0x7f25b3d20730 info='None'> failed with OSError<br>
<br>
[001] sql-tap/gh-2165-remove-support-partial-indexes.test.lua<br>
[001] TAP13 parse failed: Missing plan in the TAP source<br>
[001] [ new ]<br>
---------------------------------------------------------------------------------<br>
Statistics:<br>
* new: 1<br>
<br>
--<br>
Regards, Kirill Yukhin<br>
<br>
</div>
<base target="_self" href="https://e.mail.ru/">
</div>
</div>
</div>
</blockquote>
<br>
<br><br></BODY></HTML>