From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: Maksim Kokryashkin <max.kokryashkin@gmail.com>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/2] Print errors from __gc finalizers instead of rethrowing them. Date: Thu, 9 Nov 2023 03:03:38 +0300 [thread overview] Message-ID: <zbjypayd5r2b7s434k2pdrswdiycv2y22glerdvwdmbs4nrd3r@7ngwdloqgjjh> (raw) In-Reply-To: <ZUtE-Hy6hGePdHqI@root> Hi, Sergey! Thanks for the review. Fixed, your comments, branch is force-pushed, here is the diff: === diff --git a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua index 71efc260..450ca8d4 100644 --- a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua +++ b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-custom.test.lua @@ -21,8 +21,8 @@ local function test_f() -- Make GC aggressive enough to end the atomic phase before -- exiting the trace. collectgarbage('setstepmul', 400) - -- The number of iterations is empirical, just big enough for the - -- issue to strike. + -- The number of iterations is empirical, just big enough for + -- the issue to strike. for _ = 1, 4000 do new_bad_cdata() end diff --git a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua index dfef11e5..f0d11f6f 100644 --- a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua +++ b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default.test.lua @@ -7,5 +7,5 @@ test:plan(1) local script = require('utils').exec.makecmd(arg, { redirect = '2>&1' }) local output = script() -test:like(output, '.*ERROR in finalizer:.*') +test:like(output, 'ERROR in finalizer:') test:done(true) diff --git a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua index fdd9ced1..3fe48c77 100644 --- a/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua +++ b/test/tarantool-tests/lj-946-print-errors-from-gc-fin-default/script.lua @@ -9,8 +9,8 @@ local function test_f() -- Make GC aggressive enough to end the atomic phase before -- exiting the trace. collectgarbage('setstepmul', 400) - -- The number of iterations is empirical, just big enough for the - -- issue to strike. + -- The number of iterations is empirical, just big enough for + -- the issue to strike. for _ = 1, 4000 do new_bad_cdata() end ===
next prev parent reply other threads:[~2023-11-09 0:03 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-07 21:06 [Tarantool-patches] [PATCH luajit v2 0/2] gc: handle errors in finalizers Maksim Kokryashkin via Tarantool-patches 2023-11-07 21:06 ` [Tarantool-patches] [PATCH luajit v2 1/2] Print errors from __gc finalizers instead of rethrowing them Maksim Kokryashkin via Tarantool-patches 2023-11-08 8:21 ` Sergey Kaplun via Tarantool-patches 2023-11-09 0:03 ` Maxim Kokryashkin via Tarantool-patches [this message] 2023-11-09 12:03 ` Sergey Bronnikov via Tarantool-patches 2023-11-09 12:14 ` Maxim Kokryashkin via Tarantool-patches 2023-11-09 13:14 ` Sergey Bronnikov via Tarantool-patches 2023-11-07 21:06 ` [Tarantool-patches] [PATCH luajit v2 2/2] Fix last commit Maksim Kokryashkin via Tarantool-patches 2023-11-08 8:37 ` Sergey Kaplun via Tarantool-patches 2023-11-09 0:04 ` Maxim Kokryashkin via Tarantool-patches 2023-11-09 12:08 ` Sergey Bronnikov via Tarantool-patches 2023-11-23 6:30 ` [Tarantool-patches] [PATCH luajit v2 0/2] gc: handle errors in finalizers Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=zbjypayd5r2b7s434k2pdrswdiycv2y22glerdvwdmbs4nrd3r@7ngwdloqgjjh \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=max.kokryashkin@gmail.com \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v2 1/2] Print errors from __gc finalizers instead of rethrowing them.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox