Re: [Tarantool-patches] [PATCH luajit 10/19] Cleanup math function compilation and fix inconsistencies.

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the patch!
LGTM
On Wed, Aug 09, 2023 at 06:35:59PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> From: Mike Pall <mike>
> 
> (cherry picked from commit 5655be4546d9177890c69f0d0accac4773ff0887)
> 
> This patch backports the aforementioned patch for mips and ppc, because
> those architectures were stripped during the backporting via
> 71ec8eb232d4dfa8df2cbbae65b799b2ce493979 ("Cleanup math function
> compilation and fix inconsistencies."). This applies these missed diffs
> to prevent conflict during backporting future patches.
> 
> This patch just removes macros, that are no more in use.
> 
> Sergey Kaplun:
> * added the description for the problem
> 
> Part of tarantool/tarantool#8825
> ---
>  src/lj_asm_mips.h | 1 -
>  src/lj_asm_ppc.h  | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/src/lj_asm_mips.h b/src/lj_asm_mips.h
> index a26a82cd..c27d8413 100644
> --- a/src/lj_asm_mips.h
> +++ b/src/lj_asm_mips.h
> @@ -1794,7 +1794,6 @@ static void asm_abs(ASMState *as, IRIns *ir)
>  }
>  #endif
>  
> -#define asm_atan2(as, ir)	asm_callid(as, ir, IRCALL_atan2)
>  #define asm_ldexp(as, ir)	asm_callid(as, ir, IRCALL_ldexp)
>  
>  static void asm_arithov(ASMState *as, IRIns *ir)
> diff --git a/src/lj_asm_ppc.h b/src/lj_asm_ppc.h
> index 6cb608f7..6aaed058 100644
> --- a/src/lj_asm_ppc.h
> +++ b/src/lj_asm_ppc.h
> @@ -1390,7 +1390,6 @@ static void asm_neg(ASMState *as, IRIns *ir)
>  }
>  
>  #define asm_abs(as, ir)		asm_fpunary(as, ir, PPCI_FABS)
> -#define asm_atan2(as, ir)	asm_callid(as, ir, IRCALL_atan2)
>  #define asm_ldexp(as, ir)	asm_callid(as, ir, IRCALL_ldexp)
>  
>  static void asm_arithov(ASMState *as, IRIns *ir, PPCIns pi)
> -- 
> 2.41.0
>