Re: [Tarantool-patches] [PATCH luajit v5 2/2] test: add tests for debugging extensions

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi!
Thanks for the review!
Fixed your comments, except for the comment about CMake policy. The
policy you've mentioned is too new to include in our CMakeLists.txt.

Branch is force pushed, diff is below:
===
diff --git a/test/LuaJIT-debug-extensions-tests/CMakeLists.txt b/test/LuaJIT-debug-extensions-tests/CMakeLists.txt
index 3b38201d..1956cf2a 100644
--- a/test/LuaJIT-debug-extensions-tests/CMakeLists.txt
+++ b/test/LuaJIT-debug-extensions-tests/CMakeLists.txt
@@ -6,6 +6,15 @@ add_custom_target(LuaJIT-lldb-extension-tests
   DEPENDS ${LUAJIT_TEST_BINARY}
 )

+# Skip tests for Tarantool.
+if(ENABLE_BUNDLED_LUAJIT)
+  message(WARNING
+    "Tarantool build, LuaJIT-lldb-extension-tests and "
+    "LuaJIT-gdb-extension-tests are dummy"
+  )
+  return()
+endif()
+
 # Debug info is required for testing of extensions.
 if(NOT (CMAKE_BUILD_TYPE MATCHES Debug))
   message(WARNING
@@ -53,7 +56,7 @@ if(GDB)
     "DEBUGGER_COMMAND=${GDB}"
   )
   add_custom_command(TARGET LuaJIT-gdb-extension-tests
-    COMMENT "Running luajit_dbg.py tests with gdb"
+    COMMENT "Running debug extension tests with gdb"
     COMMAND
     ${GDB_TEST_ENV} ${PYTHON_EXECUTABLE} ${TEST_SCRIPT_PATH}
     WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
@@ -68,7 +71,7 @@ if(LLDB)
     "DEBUGGER_COMMAND=${LLDB}"
   )
   add_custom_command(TARGET LuaJIT-lldb-extension-tests
-    COMMENT "Running luajit_dbg.py tests with lldb"
+    COMMENT "Running debug extension tests with lldb"
     COMMAND
     ${LLDB_TEST_ENV} ${PYTHON_EXECUTABLE} ${TEST_SCRIPT_PATH}
     WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
diff --git a/test/LuaJIT-debug-extensions-tests/debug-extension-tests.py b/test/LuaJIT-debug-extensions-tests/debug-extension-tests.py
index 6ef87473..380e4324 100644
--- a/test/LuaJIT-debug-extensions-tests/debug-extension-tests.py
+++ b/test/LuaJIT-debug-extensions-tests/debug-extension-tests.py
@@ -247,4 +247,5 @@ for test_cls in TestCaseBase.__subclasses__():
     test_cls.test = lambda self: self.check()

 if __name__ == '__main__':
+    # XXX: Verbosity level 2 is the most verbose.
     unittest.main(verbosity=2)
===

Regards,
Maxim Kokryashkin