Re: [Tarantool-patches] [PATCH luajit v3] sysprof: fix crash during FFUNC stream

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi!
Thanks for the review!
Fixed your comment, branch is force-pushed. Diff is below:
===
diff --git a/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua b/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua
index 347bd087..90a19156 100644
--- a/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua
+++ b/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua
@@ -48,6 +48,6 @@ end
 res, err = misc.sysprof.stop()
 assert(res, err)
 
-test:ok(true, 'sysprof finished successfully')
+test:ok(true, 'FFUNC frames were streamed correctly')
 
 os.exit(test:check() and 0 or 1)
===
On Wed, Nov 08, 2023 at 06:47:28PM +0300, Sergey Bronnikov wrote:
> Hi, Max
> 
> sorry for a delayed answer.
> 
> LGTM with a minor comment
> 
> 
> On 7/14/23 17:30, Maxim Kokryashkin wrote:
> > 
> <snipped>
> > 
> > 
> >     > +end
> >     > +
> >     > +res, err = misc.sysprof.stop()
> >     > +assert(res, err)
> >     > +
> >     > +test:ok(true, 'sysprof finished successfully')
> > 
> I propose to reflect a goal of the test in a test description. Please add
> something about ffunc to description.
> 
> The test is not about whole sysprof, but about ffunc support in sysprof.
> 
> >     > +
> >     > +os.exit(test:check() and 0 or 1)
> > 
> >