Re: [Tarantool-patches] [PATCH luajit 12/19] DynASM: Fix warning.

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the patch!
LGTM as trivial, except for the single comment regarding the commit message below.
On Wed, Aug 09, 2023 at 06:36:01PM +0300, Sergey Kaplun via Tarantool-patches wrote:
> From: Mike Pall <mike>
> 
> (cherry-picked from commit 9b41062156779160b88fe5e1eb1ece1ee1fe6a74)
> 
> This patch adds the `/* fallthrough */` comments elsewhere, where it was
> missing for the ARM64 build, so the `-Wimplicit-fallthrough` [1] warning
> is trigerred.
Since there are no 'comments', but the single 'comment', I believe a better phrasing
would be:
| This patch adds the `/* fallthrough */` comment to dynasm/dasm_arm64.h, so the
| `-Wimplicit-fallthrough` [1] warning is not trigerred anymore for the ARM64 build.
> 
> [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough
> 
> Sergey Kaplun:
> * added the description for the commit
> 
> Part of tarantool/tarantool#8825
> ---
>  dynasm/dasm_arm64.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/dynasm/dasm_arm64.h b/dynasm/dasm_arm64.h
> index 47e1e074..ff21236d 100644
> --- a/dynasm/dasm_arm64.h
> +++ b/dynasm/dasm_arm64.h
> @@ -427,6 +427,7 @@ int dasm_encode(Dst_DECL, void *buffer)
>  	  break;
>  	case DASM_REL_LG:
>  	  CK(n >= 0, UNDEF_LG);
> +	  /* fallthrough */
>  	case DASM_REL_PC:
>  	  CK(n >= 0, UNDEF_PC);
>  	  n = *DASM_POS2PTR(D, n) - (int)((char *)cp - base) + 4;
> -- 
> 2.41.0
>