Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the patch!
LGTM, except for the single nit below.

On Wed, May 15, 2024 at 03:32:01PM UTC, Sergey Kaplun wrote:
> Relates to tarantool/tarantool#8473
> ---
>  .github/workflows/sanitizers-testing.yml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml
> index 154ebe40..4bf7d023 100644
> --- a/.github/workflows/sanitizers-testing.yml
> +++ b/.github/workflows/sanitizers-testing.yml
> @@ -41,7 +41,7 @@ jobs:
>              CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
>      runs-on: [self-hosted, regular, Linux, x86_64]
>      name: >
> -      LuaJIT with ASan (Linux/x86_64)
> +      LuaJIT with ASan and UBSan (Linux/x86_64)
>        ${{ matrix.BUILDTYPE }}
>        CC:${{ matrix.CC }}
>        GC64:ON SYSMALLOC:ON
> @@ -70,9 +70,10 @@ jobs:
>            cmake -S . -B ${{ env.BUILDDIR }}
>            -G Ninja
>            ${{ matrix.CMAKEFLAGS }}
> +          -DLUAJIT_ENABLE_GC64=ON
I see why this change was made, but it is irrelevant to the patch.
The decision to leave it as it is or remove is up to you.
>            -DLUAJIT_USE_ASAN=ON
>            -DLUAJIT_USE_SYSMALLOC=ON
> -          -DLUAJIT_ENABLE_GC64=ON
> +          -DLUAJIT_USE_UBSAN=ON
>        - name: build
>          run: cmake --build . --parallel
>          working-directory: ${{ env.BUILDDIR }}
> @@ -91,5 +92,8 @@ jobs:
>              symbolize=1:                     \
>              unmap_shadow_on_exit=1:          \
>            "
> +          UBSAN_OPTIONS: "
> +            print_stacktrace=1 \
> +          "
>          run: cmake --build . --parallel --target LuaJIT-test
>          working-directory: ${{ env.BUILDDIR }}
> --
> 2.45.0
>