Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: Maksim Kokryashkin <max.kokryashkin@gmail.com>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] ARM64: Allow building with unwinding disabled.
Date: Tue, 9 Jan 2024 17:18:24 +0300	[thread overview]
Message-ID: <sb2avgfnmwysv2t7obdfra3lx3wyb3avv5oewrr3dctw5z4czg@t2gtzdhb5ym3> (raw)
In-Reply-To: <d29a7b9b-03e5-499b-b9fe-96fd823bcb5b@tarantool.org>

Hi, Sergey!
Thanks for the review!
On Fri, Dec 29, 2023 at 04:40:23PM +0300, Sergey Bronnikov wrote:
> Hello, Max!
>
> thanks for the patch! LGTM with a minor comment
>
> On 12/11/23 14:26, Maksim Kokryashkin wrote:
> > From: Mike Pall <mike>
> >
> > (cherry-picked from commit 5677985dc1f19cf0a67112f4365c7fb79237fa16)
> >
> > Prior to this patch, the LuaJIT build with the
> > `-DLUAJIT_NO_UNWIND=1` option enabled failed on ARM64 because of
> > linker relocation errors related to dwarf-specific code. This
>
> probably it is worth adding an error message produced by linker.
>
> Feel free to ignore.
Added. Here is the new commit message:
===
ARM64: Allow building with unwinding disabled.

(cherry-picked from commit 5677985dc1f19cf0a67112f4365c7fb79237fa16)

Prior to this patch, the LuaJIT build with the
`-DLUAJIT_NO_UNWIND=1` option enabled failed on ARM64 because of
linker relocation error related to dwarf-specific code:
| /usr/bin/ld: lj_vm_dyn.o: relocation R_AARCH64_PREL32 against
| symbol `lj_err_unwind_dwarf' which may bind externally can not
| be used when making a shared object; recompile with -fPIC
| lj_vm_dyn.o:(.eh_frame+0x12): dangerous relocation: unsupported
| relocation

This patch disables emission of the `.eh_frame` section for
builds without unwinding to solve the issue.

The `LUAJIT_NO_UNWIND` build option is added to CMakeLists.txt.
This patch adds this build flavor to our exotic builds workflow.

Maxim Kokryashkin:
* added the description for the problem

Part of tarantool/tarantool#9145
===
>
>
> <snipped>
>

  reply	other threads:[~2024-01-09 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 11:26 Maksim Kokryashkin via Tarantool-patches
2023-12-12  9:38 ` Sergey Kaplun via Tarantool-patches
2023-12-29 13:40 ` Sergey Bronnikov via Tarantool-patches
2024-01-09 14:18   ` Maxim Kokryashkin via Tarantool-patches [this message]
2024-01-16  9:47     ` Sergey Bronnikov via Tarantool-patches
2024-02-15 13:41 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sb2avgfnmwysv2t7obdfra3lx3wyb3avv5oewrr3dctw5z4czg@t2gtzdhb5ym3 \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergeyb@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] ARM64: Allow building with unwinding disabled.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox