From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: Maksim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2 2/2] Fix last commit.
Date: Thu, 9 Nov 2023 03:04:51 +0300 [thread overview]
Message-ID: <lgnpa4w5vasyomwnucg7u66uz2bgho4673tpu3s2xyzxhlqc3c@3wl24mc4qghr> (raw)
In-Reply-To: <ZUtI3uxMhknqlFUT@root>
Hi, Sergey!
Thanks for the review!
Fixed your comments, branch is force-pushed, here is the diff:
===
diff --git a/test/tarantool-c-tests/lj-991-fix-finalizer-error-handler-init.test.c b/test/tarantool-c-tests/lj-991-fix-finalizer-error-handler-init.test.c
index 49befc29..43d1c394 100644
--- a/test/tarantool-c-tests/lj-991-fix-finalizer-error-handler-init.test.c
+++ b/test/tarantool-c-tests/lj-991-fix-finalizer-error-handler-init.test.c
@@ -12,7 +12,7 @@
static int stack_is_clean(void *test_state)
{
lua_State *L = test_state;
- assert_true(lua_gettop(L) == 0);
+ assert_true(lua_gettop(L) == 0);
return TEST_EXIT_SUCCESS;
}
===
next prev parent reply other threads:[~2023-11-09 0:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 21:06 [Tarantool-patches] [PATCH luajit v2 0/2] gc: handle errors in finalizers Maksim Kokryashkin via Tarantool-patches
2023-11-07 21:06 ` [Tarantool-patches] [PATCH luajit v2 1/2] Print errors from __gc finalizers instead of rethrowing them Maksim Kokryashkin via Tarantool-patches
2023-11-08 8:21 ` Sergey Kaplun via Tarantool-patches
2023-11-09 0:03 ` Maxim Kokryashkin via Tarantool-patches
2023-11-09 12:03 ` Sergey Bronnikov via Tarantool-patches
2023-11-09 12:14 ` Maxim Kokryashkin via Tarantool-patches
2023-11-09 13:14 ` Sergey Bronnikov via Tarantool-patches
2023-11-07 21:06 ` [Tarantool-patches] [PATCH luajit v2 2/2] Fix last commit Maksim Kokryashkin via Tarantool-patches
2023-11-08 8:37 ` Sergey Kaplun via Tarantool-patches
2023-11-09 0:04 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-11-09 12:08 ` Sergey Bronnikov via Tarantool-patches
2023-11-23 6:30 ` [Tarantool-patches] [PATCH luajit v2 0/2] gc: handle errors in finalizers Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lgnpa4w5vasyomwnucg7u66uz2bgho4673tpu3s2xyzxhlqc3c@3wl24mc4qghr \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v2 2/2] Fix last commit.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox