Re: [Tarantool-patches] [PATCH luajit 3/3] test: fix fix-mips64-spare-side-exit-patching

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
LGTM, except for the single nit regarding the commit message below.

On Mon, Sep 04, 2023 at 06:50:26PM +0300, Sergey Kaplun wrote:
> This test may be flaky due to a non-monotonic filling of the vector with
I believe, that 'sparse' is a better fit here then 'non-monotonic'. It
is just a widely adopted term for vectors like this.

> traces. Hence, `misc.getmetrics().jit_trace_num` (which is the total
> number of traces) is not the last trace number, so there is no mcode for
> it.
> 
> This patch fixes flakyness from two sides:
> * The `fillmcode()` function now starts a search from the given trace
>   itself, so there is no possible inconsistency with the growing vector.
> * The finding of the last trace number in the aforementioned test is now
>   more bulletproof: we scan all numbers from the metrics value to the
>   maxtrace value. The last number with an existing mcode is chosen as
>   the resulting last trace number.
> ---
>  ...x-mips64-spare-side-exit-patching.test.lua | 22 ++++++++++++++++---
>  test/tarantool-tests/utils/jit/generators.lua |  5 ++---
>  2 files changed, 21 insertions(+), 6 deletions(-)
<snipped>