From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>,
Nikita Pettik <korablev@tarantool.org>,
tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] vinyl: restart read iterator in case of rolled back WAL
Date: Tue, 23 Jun 2020 08:15:53 +0300 [thread overview]
Message-ID: <fff88903-ce54-e8dd-5e8f-761719a9617a@tarantool.org> (raw)
In-Reply-To: <20200619124229.GB61079@atlas>
>>> The read iterator was rewritten several times and still have at least
>>> several bugs. I think we should admit that we cannot support such a
>>> complicated solution. How about some stupid solution: if ANY change
>>> has been happened during yield - restart advancing?
> Does this statement have technical merit? Is it supported by
> tests? I'd gladly support the change if it was grounded in reason -
> evaluation of the performance impact, for example, could serve as
> a confirmation that a simple solution would be just fine.
>
> Without it, I'd it's a regress, a signature of helplessness,
> lack of courage to make things right.
Two reasons:
1. since we have to read from disk it's not a big deal to scan memory again.
2. a dozen of lines of code is removed - the cost of support is lowered
a bit.
next prev parent reply other threads:[~2020-06-23 5:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 16:46 Nikita Pettik
2020-06-01 17:40 ` Vladislav Shpilevoy
2020-06-19 12:34 ` Nikita Pettik
2020-06-20 16:33 ` Vladislav Shpilevoy
2020-06-16 12:10 ` Aleksandr Lyapunov
2020-06-19 12:24 ` Nikita Pettik
2020-06-19 12:42 ` Konstantin Osipov
2020-06-23 5:15 ` Aleksandr Lyapunov [this message]
2020-06-23 11:08 ` Konstantin Osipov
2020-06-19 13:01 ` Aleksandr Lyapunov
2020-06-24 13:41 ` Nikita Pettik
2020-06-20 16:33 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fff88903-ce54-e8dd-5e8f-761719a9617a@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] vinyl: restart read iterator in case of rolled back WAL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox