From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org
Cc: v.shpilevoy@tarantool.org
Subject: [Tarantool-patches] [PATCH 2/2] luacheck: fix warnings in test/box-tap
Date: Fri, 15 Jan 2021 14:22:31 +0300 [thread overview]
Message-ID: <ff90d2642f663e1db9f8638910d64fe219b66160.1610709207.git.sergeyb@tarantool.org> (raw)
In-Reply-To: <cover.1610709207.git.sergeyb@tarantool.org>
From: Sergey Bronnikov <sergeyb@tarantool.org>
Follows up #5457
---
test/box-tap/feedback_daemon.test.lua | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua
index 123033cda..8cfbf31d7 100755
--- a/test/box-tap/feedback_daemon.test.lua
+++ b/test/box-tap/feedback_daemon.test.lua
@@ -124,8 +124,8 @@ local fh = fio.open("feedback.json")
test:ok(fh, "file is created")
local file_data = fh:read()
-- Ignore the report time. The data should be equal other than that.
-feedback_save = string.gsub(feedback_save, 'time:(%d+)', 'time:0')
-file_data = string.gsub(feedback_save, 'time:(%d+)', 'time:0')
+feedback_save = string.gsub(feedback_save, '"time":(%d+)', 'time:0')
+file_data = string.gsub(file_data, '"time":(%d+)', 'time:0')
test:is(file_data, feedback_save, "data is equal")
fh:close()
fio.unlink("feedback.json")
@@ -247,7 +247,7 @@ box.space.features_memtx_empty:drop()
box.space.features_memtx:drop()
box.space.features_sync:drop()
-function check_stats(stat)
+local function check_stats(stat)
local sub = test:test('feedback operation stats')
sub:plan(18)
local box_stat = box.stat()
--
2.25.1
next prev parent reply other threads:[~2021-01-15 11:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 11:22 [Tarantool-patches] [PATCH 0/2] Fix new luacheck warnings in test/box-tap and test/box Sergey Bronnikov via Tarantool-patches
2021-01-15 11:22 ` [Tarantool-patches] [PATCH 1/2] luacheck: fix warnings in test/box Sergey Bronnikov via Tarantool-patches
2021-01-15 12:39 ` Serge Petrenko via Tarantool-patches
2021-01-15 12:54 ` Sergey Bronnikov via Tarantool-patches
2021-01-15 13:02 ` Serge Petrenko via Tarantool-patches
2021-01-15 20:32 ` Igor Munkin via Tarantool-patches
2021-01-15 11:22 ` Sergey Bronnikov via Tarantool-patches [this message]
2021-01-15 12:40 ` [Tarantool-patches] [PATCH 2/2] luacheck: fix warnings in test/box-tap Serge Petrenko via Tarantool-patches
2021-01-15 12:56 ` Sergey Bronnikov via Tarantool-patches
2021-01-15 13:03 ` Serge Petrenko via Tarantool-patches
2021-01-15 14:30 ` [Tarantool-patches] [PATCH 0/2] Fix new luacheck warnings in test/box-tap and test/box Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff90d2642f663e1db9f8638910d64fe219b66160.1610709207.git.sergeyb@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2] luacheck: fix warnings in test/box-tap' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox