Tarantool development patches archive
 help / color / mirror / Atom feed
From: Leonid Vasiliev <lvasiliev@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 1/2] txn_limbo: single function to confirm transactions
Date: Wed, 22 Jul 2020 18:19:21 +0300	[thread overview]
Message-ID: <ff60debc-74d2-c628-c617-99d79debbdf1@tarantool.org> (raw)
In-Reply-To: <fad3c6b9de464548d5c7fc67a012f2669dcc2968.1595371239.git.v.shpilevoy@tarantool.org>

Hi! Thank you for the patch.
LGTM.

On 22.07.2020 01:42, Vladislav Shpilevoy wrote:
> Before this patch there were some structural problems with the
> limbo code (still are now, but less).
> 
> It wasn't clear when lifetime of a transaction ends. When it it is

Double it.

  reply	other threads:[~2020-07-22 15:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 22:42 [Tarantool-patches] [PATCH 0/2] Make txn_commit() simpler Vladislav Shpilevoy
2020-07-21 22:42 ` [Tarantool-patches] [PATCH 1/2] txn_limbo: single function to confirm transactions Vladislav Shpilevoy
2020-07-22 15:19   ` Leonid Vasiliev [this message]
2020-07-21 22:42 ` [Tarantool-patches] [PATCH 2/2] txn: remove TXN_IS_DONE check from txn_commit() Vladislav Shpilevoy
2020-07-22 15:28   ` Leonid Vasiliev
2020-07-22  8:40 ` [Tarantool-patches] [PATCH 0/2] Make txn_commit() simpler Cyrill Gorcunov
2020-07-22 23:14 ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff60debc-74d2-c628-c617-99d79debbdf1@tarantool.org \
    --to=lvasiliev@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/2] txn_limbo: single function to confirm transactions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox