From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org>, Maxim Kokryashkin <m.kokryashkin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 03/36] test: refactor <lang/coroutine.lua> LuaJIT test Date: Thu, 15 Aug 2024 16:00:58 +0300 [thread overview] Message-ID: <ff5fa77e-c63b-40c6-b70f-1ce2180e84d8@tarantool.org> (raw) In-Reply-To: <8e9e2481942c2c98a1e7f078e71b29edab252fae.1723638851.git.skaplun@tarantool.org> [-- Attachment #1: Type: text/plain, Size: 3178 bytes --] Hi, Sergey! Thanks for the patch! Please see my comments. On 14.08.2024 16:55, Sergey Kaplun wrote: > This patch refactors the <lang/coroutine.lua> test by adding a simple > check for the content of a `debug.traceback()` result. Also, the test is > moved to the <lib/coroutine/> directory. The category for the test is debatable. In fact, the test target is a function from `debug` module, not coroutines. > > Also, it removes the <misc/coro_traceback.lua> since it is the same test > that wasn't cleaned up during the refactoring in the original > repository. > > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/lang/coroutine.lua | 8 -------- > test/LuaJIT-tests/lang/index | 1 - > test/LuaJIT-tests/lib/coroutine/index | 1 + > test/LuaJIT-tests/lib/coroutine/traceback.lua | 14 ++++++++++++++ > test/LuaJIT-tests/misc/coro_traceback.lua | 8 -------- > 5 files changed, 15 insertions(+), 17 deletions(-) > delete mode 100644 test/LuaJIT-tests/lang/coroutine.lua > create mode 100644 test/LuaJIT-tests/lib/coroutine/traceback.lua > delete mode 100644 test/LuaJIT-tests/misc/coro_traceback.lua > > diff --git a/test/LuaJIT-tests/lang/coroutine.lua b/test/LuaJIT-tests/lang/coroutine.lua > deleted file mode 100644 > index 405135c9..00000000 > --- a/test/LuaJIT-tests/lang/coroutine.lua > +++ /dev/null > @@ -1,8 +0,0 @@ > -do --- traceback > - local co = coroutine.create(function() > - local x = nil > - local y = x.x > - end) > - assert(coroutine.resume(co) == false) > - debug.traceback(co) > -end > diff --git a/test/LuaJIT-tests/lang/index b/test/LuaJIT-tests/lang/index > index 4ff7a297..803f32d8 100644 > --- a/test/LuaJIT-tests/lang/index > +++ b/test/LuaJIT-tests/lang/index > @@ -14,7 +14,6 @@ concat.lua > self.lua > table.lua > upvalue > -coroutine.lua > tail_recursion.lua > vararg_jit.lua > gc.lua > diff --git a/test/LuaJIT-tests/lib/coroutine/index b/test/LuaJIT-tests/lib/coroutine/index > index 9c5c17ec..c4dc6cf1 100644 > --- a/test/LuaJIT-tests/lib/coroutine/index > +++ b/test/LuaJIT-tests/lib/coroutine/index > @@ -1 +1,2 @@ > +traceback.lua > yield.lua > diff --git a/test/LuaJIT-tests/lib/coroutine/traceback.lua b/test/LuaJIT-tests/lib/coroutine/traceback.lua > new file mode 100644 > index 00000000..2b900ef1 > --- /dev/null > +++ b/test/LuaJIT-tests/lib/coroutine/traceback.lua > @@ -0,0 +1,14 @@ > +do --- traceback > + local function badfunc() > + local x = nil > + local y = x.x > + end > + > + local co = coroutine.create(badfunc) > + assert(coroutine.resume(co) == false) > + > + local traceback = debug.traceback(co) > + local line = debug.getinfo(badfunc).linedefined > + > + assert(traceback:match('traceback:.*:' .. line)) > +end > diff --git a/test/LuaJIT-tests/misc/coro_traceback.lua b/test/LuaJIT-tests/misc/coro_traceback.lua > deleted file mode 100644 > index 2676d2c6..00000000 > --- a/test/LuaJIT-tests/misc/coro_traceback.lua > +++ /dev/null > @@ -1,8 +0,0 @@ > - > -local co = coroutine.create(function() > - local x = nil > - local y = x.x > -end) > -assert(coroutine.resume(co) == false) > -debug.traceback(co) > - [-- Attachment #2: Type: text/html, Size: 4077 bytes --]
next prev parent reply other threads:[~2024-08-15 13:01 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-08-14 13:55 [Tarantool-patches] [PATCH luajit 00/36] Rearrange LuaJIT misc tests Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 01/36] test: don't run JIT-based LuaJIT tests without JIT Sergey Kaplun via Tarantool-patches 2024-08-15 12:47 ` Sergey Bronnikov via Tarantool-patches 2024-08-19 8:47 ` Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 02/36] test: enable <misc/alias_alloc.lua> LuaJIT test Sergey Kaplun via Tarantool-patches 2024-08-15 12:51 ` Sergey Bronnikov via Tarantool-patches 2024-08-15 13:31 ` Sergey Kaplun via Tarantool-patches 2024-08-30 7:25 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 03/36] test: refactor <lang/coroutine.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:00 ` Sergey Bronnikov via Tarantool-patches [this message] 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 04/36] test: remove <misc/coro_yield.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:05 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 05/36] test: enable <misc/debug_gc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:09 ` Sergey Bronnikov via Tarantool-patches 2024-08-15 13:25 ` Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 06/36] test: enable <misc/dualnum.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:11 ` Sergey Bronnikov via Tarantool-patches 2024-08-15 13:19 ` Sergey Bronnikov via Tarantool-patches 2024-08-15 13:22 ` Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 07/36] test: remove <misc/fori_coerce.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:20 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 08/36] test: remove <misc/fori_dir.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:21 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 09/36] test: remove <misc/gc_rechain.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:22 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 10/36] test: enable <misc/gc_trace.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:24 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 11/36] test: enable <misc/gcstep.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:34 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 12/36] test: enable <misc/hook_active.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:38 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 13/36] test: enable <misc/hook_line.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:42 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 14/36] test: enable <misc/hook_norecord.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:56 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 15/36] test: enable <misc/hook_record.lua> " Sergey Kaplun via Tarantool-patches 2024-08-15 13:57 ` Sergey Bronnikov via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 16/36] test: enable <misc/hook_top.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:55 ` [Tarantool-patches] [PATCH luajit 17/36] test: enable <misc/jit_flush.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 18/36] test: remove <misc/loop_unroll.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 19/36] test: enable <misc/parse_comp.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 20/36] test: enable <misc/parse_esc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 21/36] test: enable <misc/parse_misc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 22/36] test: enable <misc/phi_conv.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 23/36] test: enable <misc/recurse_deep.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 24/36] test: remove <misc/recurse_tail.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 25/36] test: enable <misc/stack_gc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 26/36] test: enable <misc/stack_purge.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 27/36] test: enable <misc/stackov.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 28/36] test: enable <misc/stackovc.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 29/36] test: enable <misc/tcall_base.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 30/36] test: enable <misc/tcall_loop.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 31/36] test: enable <misc/tonumber_scan.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 32/36] test: remove <misc/uclo.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 33/36] test: enable <misc/unordered_jit.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 34/36] test: enable <misc/wbarrier.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 35/36] test: enable <misc/wbarrier_jit.lua> " Sergey Kaplun via Tarantool-patches 2024-08-14 13:56 ` [Tarantool-patches] [PATCH luajit 36/36] test: enable <misc/wbarrier_obar.lua> " Sergey Kaplun via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ff5fa77e-c63b-40c6-b70f-1ce2180e84d8@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 03/36] test: refactor <lang/coroutine.lua> LuaJIT test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox