From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org>, Maxim Kokryashkin <m.kokryashkin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit] Fix handling of instable types in TNEW/TDUP load forwarding. Date: Fri, 15 Sep 2023 10:28:05 +0300 [thread overview] Message-ID: <fd971ff8-a478-854a-37f5-b71ae6aff733@tarantool.org> (raw) In-Reply-To: <20230829095440.30540-1-skaplun@tarantool.org> Hi, Sergey thanks for the patch! LGTM And see my minor comments below. On 8/29/23 12:54, Sergey Kaplun wrote: <snipped> > -- TDUP. > ---[[ > --- FIXME: Disable test case for now. Enable, with another > --- backported commit with a fix for the aforementioned issue > --- (and after patch "Improve assertions."). > --- Test taken trace exits too. > for _ = 1, 5 do > local t = slot > -- Now use constant key slot to get necessary branch. > @@ -48,6 +43,5 @@ for _ = 1, 5 do Nit: assert is triggered with 3 iterations too > slot = _ % 2 ~= 0 and stored_tab or {true} Nit: I would left a comment with explanation why exactly this value is assigned to slot. > end > test:is(result, true, 'TDUP load forwarding was successful') > -]] > > test:done(true)
next prev parent reply other threads:[~2023-09-15 7:28 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-29 9:54 Sergey Kaplun via Tarantool-patches 2023-08-30 10:37 ` Maxim Kokryashkin via Tarantool-patches 2023-09-15 7:28 ` Sergey Bronnikov via Tarantool-patches [this message] 2023-09-15 13:20 ` Sergey Kaplun via Tarantool-patches 2023-09-16 17:35 ` Sergey Bronnikov via Tarantool-patches 2023-09-27 12:33 ` Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fd971ff8-a478-854a-37f5-b71ae6aff733@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit] Fix handling of instable types in TNEW/TDUP load forwarding.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox