From: Peter Gulutzan <pgulutzan@ocelot.ca> To: Timur Safin <tsafin@tarantool.org>, 'Chris Sosnin' <k.sosnin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 0/4] session settings fixes Date: Wed, 8 Apr 2020 09:03:43 -0600 [thread overview] Message-ID: <fceeb274-0c7f-851d-db49-6ebb542cfd49@ocelot.ca> (raw) In-Reply-To: <0ab201d60d89$c39dd5f0$4ad981d0$@tarantool.org> On 2020-04-08 3:40 a.m., Timur Safin wrote: <cut> > Peter, after multiple rounds of discussions here (one incompatible way against another incompatible way) we tend to prefer the simpler syntax > > SET SESSION sqlconfigname = value > > because it's quite simpler, looks similar to MySQL way (though still is not part of standard), and would require less intrusive patch to parser. Introducing all configuration settins as separate system spaces (via hardcoding in the engine) looked to us slightly more intrusive (while still being not as much closer to the standard way). > > Minuses against minuses on both sides. > > What do you think, Peter? My main objection to SETTING SET was that it might cause an existing legal statement to become illegal. I have asked C. Sosnin whether SET SESSION solves that. My other objection was about proprietary syntax. SET SESSION is not extremely different from standard SQL SET SESSION CHARACTERISTICS (which I realize is too long), and proprietary syntax is less bad if another vendor does it. Incidentally MySQL handles this correctly: CREATE PROCEDURE p() BEGIN DECLARE session INTEGER; SET session = 5; END; Eventually, when Tarantool supports declared variables, I hope everyone will remember that should be legal. Thank you for considering alternative suggestions. Please proceed with what you all regard as least intrusive. Peter Gulutzan
next prev parent reply other threads:[~2020-04-08 15:03 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-03 17:09 Peter Gulutzan 2020-04-03 18:11 ` Timur Safin 2020-04-07 16:32 ` Chris Sosnin 2020-04-08 9:40 ` Timur Safin 2020-04-08 15:03 ` Peter Gulutzan [this message] 2020-04-08 14:36 ` Peter Gulutzan -- strict thread matches above, loose matches on Subject: below -- 2020-03-30 9:13 Chris Sosnin 2020-04-02 9:14 ` Timur Safin 2020-04-02 10:18 ` Chris Sosnin 2020-04-03 12:47 ` Nikita Pettik 2020-04-03 13:09 ` Nikita Pettik 2020-04-03 14:02 ` Chris Sosnin 2020-04-13 14:18 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fceeb274-0c7f-851d-db49-6ebb542cfd49@ocelot.ca \ --to=pgulutzan@ocelot.ca \ --cc=k.sosnin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=tsafin@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 0/4] session settings fixes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox