From: Georgy Kirichenko <georgy@tarantool.org> To: tarantool-patches@freelists.org Cc: Georgy Kirichenko <georgy@tarantool.org> Subject: [tarantool-patches] [PATCH v3 04/14] ddl: place alter structures onto a txn memory region Date: Sun, 9 Jun 2019 23:44:33 +0300 [thread overview] Message-ID: <fca9600e242185c4e6a53507887f13eb45d64399.1560112747.git.georgy@tarantool.org> (raw) In-Reply-To: <cover.1560112747.git.georgy@tarantool.org> As alter schema triggers lifecycle is bound with a transaction so corresponding structures should be placed onto a txn memory region instead of a fiber gc space. Prerequisites: #1254 --- src/box/alter.cc | 8 ++++---- src/box/vinyl.c | 10 ++++------ 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/src/box/alter.cc b/src/box/alter.cc index c4a1c52a9..671209b51 100644 --- a/src/box/alter.cc +++ b/src/box/alter.cc @@ -668,7 +668,7 @@ public: void *operator new(size_t size) { - return region_aligned_calloc_xc(&fiber()->gc, size, + return region_aligned_calloc_xc(&in_txn()->region, size, alignof(uint64_t)); } void operator delete(void * /* ptr */) {} @@ -682,7 +682,7 @@ static struct trigger * txn_alter_trigger_new(trigger_f run, void *data) { struct trigger *trigger = (struct trigger *) - region_calloc_object_xc(&fiber()->gc, struct trigger); + txn_alloc(in_txn(), sizeof(struct trigger)); trigger->run = run; trigger->data = data; trigger->destroy = NULL; @@ -718,7 +718,7 @@ static struct alter_space * alter_space_new(struct space *old_space) { struct alter_space *alter = - region_calloc_object_xc(&fiber()->gc, struct alter_space); + region_calloc_object_xc(&in_txn()->region, struct alter_space); rlist_create(&alter->ops); alter->old_space = old_space; alter->space_def = space_def_dup_xc(alter->old_space->def); @@ -3246,7 +3246,7 @@ on_replace_dd_sequence(struct trigger * /* trigger */, void *event) struct tuple *new_tuple = stmt->new_tuple; struct alter_sequence *alter = - region_calloc_object_xc(&fiber()->gc, struct alter_sequence); + region_calloc_object_xc(&txn->region, struct alter_sequence); struct sequence_def *new_def = NULL; auto def_guard = make_scoped_guard([=] { free(new_def); }); diff --git a/src/box/vinyl.c b/src/box/vinyl.c index 8286fed7c..e37631064 100644 --- a/src/box/vinyl.c +++ b/src/box/vinyl.c @@ -4618,19 +4618,17 @@ vy_deferred_delete_on_replace(struct trigger *trigger, void *event) * which will propagate the WAL row LSN to * the LSM tree. */ - struct trigger *on_commit = region_alloc(&fiber()->gc, - sizeof(*on_commit)); + struct trigger *on_commit = txn_alloc(txn, sizeof(*on_commit)); if (on_commit == NULL) { diag_set(OutOfMemory, sizeof(*on_commit), - "region", "struct trigger"); + "txn region", "struct trigger"); rc = -1; break; } - struct trigger *on_rollback = region_alloc(&fiber()->gc, - sizeof(*on_commit)); + struct trigger *on_rollback = txn_alloc(txn, sizeof(*on_commit)); if (on_rollback == NULL) { diag_set(OutOfMemory, sizeof(*on_commit), - "region", "struct trigger"); + "txn region", "struct trigger"); rc = -1; break; } -- 2.21.0
next prev parent reply other threads:[~2019-06-09 20:44 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-09 20:44 [tarantool-patches] [PATCH v3 00/14] Parallel applier Georgy Kirichenko 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 01/14] txn: Fire a trigger after a transaction finalization Georgy Kirichenko 2019-06-09 21:59 ` [tarantool-patches] " Konstantin Osipov 2019-06-11 11:42 ` [tarantool-patches] " Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 02/14] ddl: synchronize privileges cache with actual data state Georgy Kirichenko 2019-06-11 13:13 ` Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 03/14] txn: transaction memory allocation Georgy Kirichenko 2019-06-09 20:44 ` Georgy Kirichenko [this message] 2019-06-11 14:14 ` [tarantool-patches] [PATCH v3 04/14] ddl: place alter structures onto a txn memory region Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 05/14] txn: get rid of autocommit from a txn structure Georgy Kirichenko 2019-06-13 14:11 ` Vladimir Davydov 2019-06-16 16:20 ` [tarantool-patches] " Konstantin Osipov 2019-06-16 16:14 ` Konstantin Osipov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 06/14] txn: get rid of fiber_gc from txn_rollback Georgy Kirichenko 2019-06-13 14:12 ` Vladimir Davydov 2019-06-13 19:28 ` Георгий Кириченко 2019-06-14 9:21 ` Vladimir Davydov 2019-06-16 16:38 ` [tarantool-patches] " Konstantin Osipov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 07/14] wal: remove fiber from a journal_entry structure Georgy Kirichenko 2019-06-13 14:17 ` Vladimir Davydov 2019-06-13 19:33 ` Георгий Кириченко 2019-06-14 8:05 ` Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 08/14] wal: enable asyncronous wal writes Georgy Kirichenko 2019-06-13 14:21 ` Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 09/14] wal: a dedicated wal scheduling fiber Georgy Kirichenko 2019-06-13 14:24 ` Vladimir Davydov 2019-06-13 19:36 ` Георгий Кириченко 2019-06-14 9:20 ` Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 10/14] core: latch_unlock_external routine Georgy Kirichenko 2019-06-13 14:27 ` Vladimir Davydov 2019-06-13 19:38 ` Георгий Кириченко 2019-06-14 8:10 ` Vladimir Davydov 2019-06-14 9:18 ` Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 11/14] txn: introduce asynchronous txn commit Georgy Kirichenko 2019-06-13 14:34 ` Vladimir Davydov 2019-06-13 19:45 ` Георгий Кириченко 2019-06-14 7:58 ` Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 12/14] txn: handle fiber stop event at transaction level Georgy Kirichenko 2019-06-13 14:36 ` Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 13/14] applier: apply transaction in parallel Georgy Kirichenko 2019-06-13 15:17 ` Vladimir Davydov 2019-06-09 20:44 ` [tarantool-patches] [PATCH v3 14/14] test: fix flaky test Georgy Kirichenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fca9600e242185c4e6a53507887f13eb45d64399.1560112747.git.georgy@tarantool.org \ --to=georgy@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [tarantool-patches] [PATCH v3 04/14] ddl: place alter structures onto a txn memory region' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox