From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
gorcunov@tarantool.org, sergos@tarantool.org,
lvasiliev@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/4] make master send only confirmed data during join
Date: Mon, 29 Jun 2020 23:14:15 +0200 [thread overview]
Message-ID: <fc99bb17-a7a4-3670-337a-022d4047282c@tarantool.org> (raw)
In-Reply-To: <cover.1593444131.git.sergepetrenko@tarantool.org>
Hi! Thanks for the patch!
All looks fine at a first glance. I propose to add any fixes as tosquash
commits if any will appear.
prev parent reply other threads:[~2020-06-29 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 15:32 Serge Petrenko
2020-06-29 15:32 ` [Tarantool-patches] [PATCH 1/4] [tosquash] move wait_confirm from gc.c to txn_limbo.c Serge Petrenko
2020-06-29 15:32 ` [Tarantool-patches] [PATCH 2/4] txn_limbo: add diag_set in txn_limbo_wait_confirm Serge Petrenko
2020-06-29 15:32 ` [Tarantool-patches] [PATCH 3/4] replication: delay initial join until confirmation Serge Petrenko
2020-06-29 15:32 ` [Tarantool-patches] [PATCH 4/4] replication: only send confirmed data during final join Serge Petrenko
2020-06-29 21:14 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc99bb17-a7a4-3670-337a-022d4047282c@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/4] make master send only confirmed data during join' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox