Re: [tarantool-patches] Re: [PATCH v3 2/6] box: rework box_lua_{call, eval} to use input port

[Kirill Shcherbatov <kshcherbatov@tarantool.org>]

On 17.06.2019 12:35, Konstantin Osipov wrote:
> * Kirill Shcherbatov <kshcherbatov@tarantool.org> [19/06/13 17:18]:
>> Re-factor box_lua_call and box_lua_eval so that they don't take
>> call_request. This approach is more scalable: in case of a
>> functional index, the user expects to see a tuple with field
>> names so we should be able to pass not only raw msgpack, but
>> also a tuple to a Lua call so we need an universal way to pass
>> arguments to _call methods.
> 
> I think get_msgpack() is a violation of encapsulation - you call
> "get_msgpack" to later push the port arguments to C stack, is that
> right? So you should call port:dump_c() instead, shouldn't you?

No, this is msgpack serializer; not to obuf, but as a memory region.
In further patches this endpoint is implemented with region allocation
for port_lua e.g.